search

GoogleCloudPlatform / k8s-cloud-provider

Support code for implementing a Kubernetes cloud provider for Google Cloud Platform
Apache License 2.0
37 stars 46 forks source link

Fix compression mode #222

Closed akwi-github closed 2 months ago

akwi-github commented 3 months ago

We need to leave compression mode empty as Compression mode can only be specified with EXTERNAL or EXTERNAL_MANAGED load balancing scheme. In order to do so we need to allow zero value on the field.

akwi-github commented 3 months ago

\cc @kl52752

akwi-github commented 3 months ago

/cc @kl52752 @AwesomePatrol @mag-kol

robscott commented 3 months ago

/cc @bowei

akwi-github commented 3 months ago

/cc @bowei

kl52752 commented 3 months ago

/lgtm /approve

akwi-github commented 3 months ago

/assign @bowei

bowei commented 2 months ago

/approve

google-oss-prow[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akwi-github, bowei, kl52752

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/k8s-cloud-provider/blob/master/OWNERS)~~ [bowei] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
bowei commented 2 months ago

I'm approving the unblock the PR, but I'm not entirely certain the current type traits are doing what we need to do. I would appreciate if after we build out an initial set of use cases that we re-evaluate whether or not it supports what we need as currently implemented.

kl52752 commented 2 months ago

I'm approving the unblock the PR, but I'm not entirely certain the current type traits are doing what we need to do. I would appreciate if after we build out an initial set of use cases that we re-evaluate whether or not it supports what we need as currently implemented.

The problem with this field is that it is mandatory only if backend service type is External. We cannot introduce that complex validation so we are leaving this to the Users to set the fields properly.