search

GoogleCloudPlatform / k8s-cloud-provider

Support code for implementing a Kubernetes cloud provider for Google Cloud Platform
Apache License 2.0
37 stars 46 forks source link

Add Fallback Cleanup #225

Closed AwesomePatrol closed 4 weeks ago

AwesomePatrol commented 1 month ago

In some cases (like the recent ensure test) it failed to clean up resources after the test run. Fallback mechanism will remove all resources from the project that match test prefix and runID.

List calls to Meshes/TcpRoutes are fixed in https://github.com/GoogleCloudPlatform/k8s-cloud-provider/pull/226

Also, fixed some minor issues in tests.

Bug: b/352484069

AwesomePatrol commented 1 month ago

Please let me know if you would prefer to gate this behavior behind a flag so it is used in CI only.

/cc @akwi-github /assign @kl52752

bowei commented 1 month ago

/lgtm /approve

google-oss-prow[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AwesomePatrol, bowei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[e2e/OWNERS](https://github.com/GoogleCloudPlatform/k8s-cloud-provider/blob/master/e2e/OWNERS)~~ [bowei] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
AwesomePatrol commented 4 weeks ago

/test all