search

GoogleCloudPlatform / k8s-cloud-provider

Support code for implementing a Kubernetes cloud provider for Google Cloud Platform
Apache License 2.0
37 stars 46 forks source link

Fix calls to NetworkServices List #226

Closed AwesomePatrol closed 3 weeks ago

AwesomePatrol commented 1 month ago

It takes parent (which contains projectID and location) argument, but projectID was provided instead.

Bug: b/364244347

AwesomePatrol commented 1 month ago

/cc @akwi-github /assign @bowei

AwesomePatrol commented 4 weeks ago

/test

google-oss-prow[bot] commented 4 weeks ago

@AwesomePatrol: The /test command needs one or more targets. The following commands are available to trigger required jobs:

Use /test all to run all jobs.

In response to [this](https://github.com/GoogleCloudPlatform/k8s-cloud-provider/pull/226#issuecomment-2329565793): >/test Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
AwesomePatrol commented 4 weeks ago

/test all

AwesomePatrol commented 4 weeks ago

/test pull-k8s-cloud-provider-test

bowei commented 3 weeks ago

/lgtm /approve

google-oss-prow[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AwesomePatrol, bowei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/k8s-cloud-provider/blob/master/OWNERS)~~ [bowei] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment