search

GoogleCloudPlatform / k8s-cloud-provider

Support code for implementing a Kubernetes cloud provider for Google Cloud Platform
Apache License 2.0
37 stars 46 forks source link

Change BackendService beta API tests #227

Open kl52752 opened 3 weeks ago

kl52752 commented 3 weeks ago

Fields present in beta.BackendService API might be promoted to v1 any time and it is hard to follow that changes. Having a test that checks that fields are present only in beta API and checkst that conversion between Ga and Beta version fails are unstable and hard to maintain. Removing this logic from tests.

google-oss-prow[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kl52752 Once this PR has been reviewed and has the lgtm label, please assign bowei for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/GoogleCloudPlatform/k8s-cloud-provider/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kl52752 commented 3 weeks ago

/cc @AwesomePatrol

bowei commented 3 weeks ago

The whole point of the testing that conversion works is to make sure someone is paying attention and updates the code when the GA APIs are introduced.

What is the mitigation on how are we going to track a change if we remove the test?

kl52752 commented 3 weeks ago

The problem with those test is that it is hard to maintain it across different version of API. The best way to test it is t really on e2e tests