search

GoogleCloudPlatform / k8s-cloud-provider

Support code for implementing a Kubernetes cloud provider for Google Cloud Platform
Apache License 2.0
37 stars 46 forks source link

Add resource key to observer CallContext. #228

Closed briantkennedy closed 2 weeks ago

briantkennedy commented 3 weeks ago

This allows the observer to know the location for the given operation.

kl52752 commented 2 weeks ago

/lgtm

briantkennedy commented 2 weeks ago

@bowei this needs your approval

briantkennedy commented 2 weeks ago

@bowei

bowei commented 2 weeks ago

/lgtm /approve

google-oss-prow[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, briantkennedy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/k8s-cloud-provider/blob/master/OWNERS)~~ [bowei] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment