search

GoogleCloudPlatform / k8s-cloud-provider

Support code for implementing a Kubernetes cloud provider for Google Cloud Platform
Apache License 2.0
37 stars 46 forks source link

Fix observe_test.go #230

Closed briantkennedy closed 1 week ago

bowei commented 2 weeks ago

Brian -- is there something wrong with your gen.go?

briantkennedy commented 2 weeks ago

gen.go is fixed now, but for some reason it's showing lines that were added in a prior commit.

bowei commented 1 week ago

might be a github bug

/lgtm /approve

google-oss-prow[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, briantkennedy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/k8s-cloud-provider/blob/master/OWNERS)~~ [bowei] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment