GoogleCloudPlatform / k8s-config-connector

GCP Config Connector, a Kubernetes add-on for managing GCP resources
https://cloud.google.com/config-connector/docs/overview
Apache License 2.0
889 stars 219 forks source link

PromQL support for MonitoringDashboard #1749

Closed areyia closed 1 month ago

areyia commented 4 months ago

Hi, I recently discovered MonitoringDashboard and is something that we are looking into. Looking at the CRD, it appears that the only query language supported is the MQL, not promQL. The JSON model for the dashboard appears to have a distinction under 'timeSeriesQuery', via either 'prometheusQuery' or 'timeSeriesQueryLanguage', with only the latter supported via the CRD. Is this something that is already on the team's roadmap? This would be really useful for us to move all our dashboards from a 3rd party app into Cloud Monitoring. Thanks!

davidcollom commented 3 months ago

I needed this for this myself and it looks like this will be included within the 1.120.0 release:

https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/v1.120.0/scripts/generate-google3-docs/resource-reference/generated/resource-docs/monitoring/monitoringdashboard.md

areyia commented 1 month ago

Thanks, can confirm that this is now supported! Closing this issue.