search

GoogleCloudPlatform / k8s-config-connector

GCP Config Connector, a Kubernetes add-on for managing GCP resources
https://cloud.google.com/config-connector/docs/overview
Apache License 2.0
866 stars 204 forks source link

feat: add ExternalReference (selfLink) with GCP update/deletion uniqueness guardrail #2020

Closed yuwenma closed 1 month ago

yuwenma commented 1 month ago

Follow up PR to resolve comment in https://github.com/GoogleCloudPlatform/k8s-config-connector/pull/1920#discussion_r1630938449

justinsb commented 1 month ago

You have some conflicts, but...

/approve /lgtm

justinsb commented 1 month ago

Thanks - looks great!

/approve /lgtm

google-oss-prow[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/master/OWNERS)~~ [justinsb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment