GoogleCloudPlatform / k8s-config-connector

GCP Config Connector, a Kubernetes add-on for managing GCP resources
https://cloud.google.com/config-connector/docs/overview
Apache License 2.0
866 stars 204 forks source link

Compositions: Replace boolean for ResourceStatus.isHealthy with string enum. #2021

Closed hankfreund closed 1 month ago

hankfreund commented 1 month ago

Change description

Replace boolean for ResourceStatus.isHealthy with string enum per request on PR #2017. The currently supported values are "Healthy" and "Unhealthy".

Tests you have done

Deployed to a KIND cluster and applied a test composition (experiments/compositions/composition/tests/data/TestSimpleDeleteFacade/input.yaml). Described the composition to see the status:

Status:
  Composition Generation:  1
  Composition UID:         f8fa482a-4e35-48b1-b28d-934a5bb7f489
  Conditions:
    Last Transition Time:  2024-06-17T17:51:42Z
    Message:               Evaluated and Applied stages: project
    Reason:                ProcessedAllStages
    Status:                True
    Type:                  Ready
  Generation:              2
  Input Generation:        1
  Stages:
    Project:
      Applied Count:  1
      Last Applied:
        Health:        Healthy
        Kind:          ConfigMap
        Name:          proj-a
        Namespace:     team-a
        Status:        Resource is always ready
        Version:       v1
      Resource Count:  1
hankfreund commented 1 month ago

/assign @barney-s

barney-s commented 1 month ago

/approve /lgtm

Thank you so much @hankfreund

google-oss-prow[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: barney-s

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/master/OWNERS)~~ [barney-s] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment