search

GoogleCloudPlatform / k8s-config-connector

GCP Config Connector, a Kubernetes add-on for managing GCP resources
https://cloud.google.com/config-connector/docs/overview
Apache License 2.0
866 stars 204 forks source link

feat: promote CloudIDSEndpoint to beta #2028

Closed acpana closed 1 month ago

acpana commented 1 month ago

Patch promotes CloudIDSEndpoint to beta

yuwenma commented 1 month ago

/lgtm

Defer to @maqiuyujoyce since this is a TF related change.

maqiuyujoyce commented 1 month ago

Could you also update the PR description to reflect the latest snapshot of this PR?

maqiuyujoyce commented 1 month ago

@gemmahou fyi in case you're interested in the comments. There are some edge case scenarios in this PR as this resource is getting promoted to v1beta1 and it doesn't have comprehensive public doc.

google-oss-prow[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maqiuyujoyce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/master/OWNERS)~~ [maqiuyujoyce] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment