Closed 600lyy closed 3 months ago
/lgtm
PR looks good. @600lyy could you fix the presubmit check?
Looks like I can do the rebase / cleanup; just pushed to the PR branch 🤞
Looks like a (simple) rebase was all that was needed - thank you @600lyy
/approve /lgtm
@maqiuyujoyce I think we should merge this before #2075
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: justinsb
The full list of commands accepted by this bot can be found here.
The pull request process is described here
@justinsb as long as we don't cut a release, the order to merge #2051 and #2075 shouldn't matter.
/lgtm
Change description
Add support for soft delete policy for Google storage bucket.
The bucket's soft delete policy, which defines the period of time that soft-deleted objects will be retained, and cannot be permanently deleted. If it is not provided, by default Google Cloud Storage sets this to default soft delete policy`
This is the implementation for https://github.com/GoogleCloudPlatform/k8s-config-connector/issues/2046
make ready-pr
to ensure this PR is ready for review.