GoogleCloudPlatform / k8s-config-connector

GCP Config Connector, a Kubernetes add-on for managing GCP resources
https://cloud.google.com/config-connector/docs/overview
Apache License 2.0
889 stars 218 forks source link

Implementing soft delete for storage bucket #2051

Closed 600lyy closed 3 months ago

600lyy commented 3 months ago

Change description

Add support for soft delete policy for Google storage bucket.

The bucket's soft delete policy, which defines the period of time that soft-deleted objects will be retained, and cannot be permanently deleted. If it is not provided, by default Google Cloud Storage sets this to default soft delete policy`

This is the implementation for https://github.com/GoogleCloudPlatform/k8s-config-connector/issues/2046

yuwenma commented 3 months ago

/lgtm

PR looks good. @600lyy could you fix the presubmit check?

justinsb commented 3 months ago

Looks like I can do the rebase / cleanup; just pushed to the PR branch 🤞

justinsb commented 3 months ago

Looks like a (simple) rebase was all that was needed - thank you @600lyy

/approve /lgtm

@maqiuyujoyce I think we should merge this before #2075

google-oss-prow[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/master/OWNERS)~~ [justinsb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
maqiuyujoyce commented 3 months ago

@justinsb as long as we don't cut a release, the order to merge #2051 and #2075 shouldn't matter.

/lgtm