search

GoogleCloudPlatform / k8s-config-connector

GCP Config Connector, a Kubernetes add-on for managing GCP resources
https://cloud.google.com/config-connector/docs/overview
Apache License 2.0
862 stars 202 forks source link

chore: update protobuf libraries #2052

Closed justinsb closed 2 weeks ago

barney-s commented 3 weeks ago

@justinsb - Do you mind running "make build-protos" and if there are changes in the proto files add it as part of the commit,

justinsb commented 3 weeks ago

Do you mind running "make build-protos" and if there are changes in the proto files add it as part of the commit,

I'm happy to do that, but I don't think it's related to this PR, so I can do it separately

yuwenma commented 2 weeks ago

/lgtm /approve

I missed this one before, thinking it was for the composition only

google-oss-prow[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yuwenma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/master/OWNERS)~~ [yuwenma] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment