search

GoogleCloudPlatform / k8s-config-connector

GCP Config Connector, a Kubernetes add-on for managing GCP resources
https://cloud.google.com/config-connector/docs/overview
Apache License 2.0
862 stars 202 forks source link

fix: make ready-pr #2055

Closed jasonvigil closed 3 weeks ago

jasonvigil commented 3 weeks ago

Change description

Seem to have some diff / errors from monitoringdashboard in presubmit. Ran make ready-pr to fix.

justinsb commented 3 weeks ago

Hmm ... whoops! Thanks for fixing.

(I'll probably have to add this back in eventually, but I don't want to hold up other PRs!)

justinsb commented 3 weeks ago

/approve /lgtm

google-oss-prow[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/master/OWNERS)~~ [justinsb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment