GoogleCloudPlatform / k8s-config-connector

GCP Config Connector, a Kubernetes add-on for managing GCP resources
https://cloud.google.com/config-connector/docs/overview
Apache License 2.0
862 stars 202 forks source link

Fix value template for global ComputeTargetHTTPSProxy #2056

Closed gemmahou closed 1 week ago

gemmahou commented 3 weeks ago

Change description

Fixes b/345274481

Fix value template for global ComputeTargetHTTPSProxy. Resource created successfully:

Events:
  Type     Reason              Age              From                                Message
  ----     ------              ----             ----                                -------
  Warning  DependencyNotFound  49s              computetargethttpsproxy-controller  reference ComputeURLMap default/computetargethttpsproxy-dep-certmgr is not found
  Normal   Updating            16s              computetargethttpsproxy-controller  Update in progress
  Normal   UpToDate            4s (x2 over 5s)  computetargethttpsproxy-controller  The resource is up to date

Tests you have done

justinsb commented 2 weeks ago

Looks good; is this covered by a test?

maqiuyujoyce commented 2 weeks ago

/lgtm

Agreed with @justinsb that we should add a test case for it.

gemmahou commented 2 weeks ago

Added dynamic test to cover certificateMapRef field

--- PASS: TestCreateNoChangeUpdateDelete (0.12s)
    --- PASS: TestCreateNoChangeUpdateDelete/compute (0.00s)
        --- PASS: TestCreateNoChangeUpdateDelete/compute/basic-globaltargethttpsproxy (301.47s)
PASS
{"severity":"info","timestamp":"2024-06-24T18:48:56.177Z","msg":"Stopping and waiting for non leader election runnables"}
{"severity":"info","timestamp":"2024-06-24T18:48:56.177Z","msg":"Stopping and waiting for leader election runnables"}
{"severity":"info","timestamp":"2024-06-24T18:48:56.177Z","msg":"Stopping and waiting for caches"}
{"severity":"info","timestamp":"2024-06-24T18:48:56.177Z","msg":"Stopping and waiting for webhooks"}
{"severity":"info","timestamp":"2024-06-24T18:48:56.177Z","logger":"controller-runtime.webhook","msg":"Shutting down webhook server with timeout of 1 minute"}
{"severity":"info","timestamp":"2024-06-24T18:48:56.177Z","msg":"Wait completed, proceeding to shutdown the manager"}
ok      github.com/GoogleCloudPlatform/k8s-config-connector/pkg/controller/dynamic      311.376s
yuwenma commented 2 weeks ago

/lgtm

Defer to @maqiuyujoyce comment on verifying the field and updating the doc.

yuwenma commented 2 weeks ago

/lgtm /approve

Thank you for the change, looks good on my side

/hold In case @maqiuyujoyce want to take another pass. Feel free to unhold

maqiuyujoyce commented 2 weeks ago

/lgtm /approve

google-oss-prow[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maqiuyujoyce, yuwenma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/master/OWNERS)~~ [maqiuyujoyce,yuwenma] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
yuwenma commented 1 week ago

/hold cancel