Closed gemmahou closed 1 week ago
Looks good; is this covered by a test?
/lgtm
Agreed with @justinsb that we should add a test case for it.
Added dynamic test to cover certificateMapRef
field
--- PASS: TestCreateNoChangeUpdateDelete (0.12s)
--- PASS: TestCreateNoChangeUpdateDelete/compute (0.00s)
--- PASS: TestCreateNoChangeUpdateDelete/compute/basic-globaltargethttpsproxy (301.47s)
PASS
{"severity":"info","timestamp":"2024-06-24T18:48:56.177Z","msg":"Stopping and waiting for non leader election runnables"}
{"severity":"info","timestamp":"2024-06-24T18:48:56.177Z","msg":"Stopping and waiting for leader election runnables"}
{"severity":"info","timestamp":"2024-06-24T18:48:56.177Z","msg":"Stopping and waiting for caches"}
{"severity":"info","timestamp":"2024-06-24T18:48:56.177Z","msg":"Stopping and waiting for webhooks"}
{"severity":"info","timestamp":"2024-06-24T18:48:56.177Z","logger":"controller-runtime.webhook","msg":"Shutting down webhook server with timeout of 1 minute"}
{"severity":"info","timestamp":"2024-06-24T18:48:56.177Z","msg":"Wait completed, proceeding to shutdown the manager"}
ok github.com/GoogleCloudPlatform/k8s-config-connector/pkg/controller/dynamic 311.376s
/lgtm
Defer to @maqiuyujoyce comment on verifying the field and updating the doc.
/lgtm /approve
Thank you for the change, looks good on my side
/hold In case @maqiuyujoyce want to take another pass. Feel free to unhold
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: maqiuyujoyce, yuwenma
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/hold cancel
Change description
Fixes b/345274481
Fix value template for global ComputeTargetHTTPSProxy. Resource created successfully:
Tests you have done
make ready-pr
to ensure this PR is ready for review.