search

GoogleCloudPlatform / k8s-config-connector

GCP Config Connector, a Kubernetes add-on for managing GCP resources
https://cloud.google.com/config-connector/docs/overview
Apache License 2.0
862 stars 202 forks source link

feat: Turn on stricter golden log check in e2e fixture (part 2) #2061

Closed yuwenma closed 2 weeks ago

yuwenma commented 2 weeks ago

Turn on the stricter golden log check in fixture presubmit. This is the second part and needs https://github.com/GoogleCloudPlatform/k8s-config-connector/pull/1934 to merge first.

justinsb commented 2 weeks ago

/approve /lgtm

google-oss-prow[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/master/OWNERS)~~ [justinsb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment