search

GoogleCloudPlatform / k8s-config-connector

GCP Config Connector, a Kubernetes add-on for managing GCP resources
https://cloud.google.com/config-connector/docs/overview
Apache License 2.0
862 stars 202 forks source link

chore: normalize status.observedState.etag in golden tests #2064

Closed justinsb closed 2 weeks ago

justinsb commented 2 weeks ago

Also simplify etag computation, as we don't rely on the value itself any more.

justinsb commented 2 weeks ago

/assign @yuwenma

justinsb commented 2 weeks ago

(I did this because it blocked https://github.com/GoogleCloudPlatform/k8s-config-connector/pull/2052 )

yuwenma commented 2 weeks ago

/lgtm /approve

(I did this because it blocked #2052 )

Ah! Fair

google-oss-prow[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yuwenma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/master/OWNERS)~~ [yuwenma] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment