search

GoogleCloudPlatform / k8s-config-connector

GCP Config Connector, a Kubernetes add-on for managing GCP resources
https://cloud.google.com/config-connector/docs/overview
Apache License 2.0
862 stars 202 forks source link

Make context optional for evaluation #2065

Closed barney-s closed 2 weeks ago

barney-s commented 2 weeks ago

Change description

This is to allow simpler compositions and especially compositions that don't use any cloud resources.

barney-s commented 2 weeks ago

/assign @cheftako /assign @xiaoweim

xiaoweim commented 2 weeks ago

Looks good, does this mean that not all composition uses context? (since so far my understanding is that all compositions use context and will generate a plan)

barney-s commented 2 weeks ago

Looks good, does this mean that not all composition uses context? (since so far my understanding is that all compositions use context and will generate a plan)

Yes for non-cloud resources, context is optional.

xiaoweim commented 2 weeks ago

/lgtm /approve

google-oss-prow[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiaoweim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/master/OWNERS)~~ [xiaoweim] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment