search

GoogleCloudPlatform / k8s-config-connector

GCP Config Connector, a Kubernetes add-on for managing GCP resources
https://cloud.google.com/config-connector/docs/overview
Apache License 2.0
889 stars 218 forks source link

fix: Trigger updates for mysqlinstance + sqlserverinstance mockgcp tests #2074

Closed jasonvigil closed 3 months ago

jasonvigil commented 3 months ago

Change description

Seems that the existing metadata.labels changes do not incur updates to the resources. So that we exercise the mockgcp update path, made some changes to spec.settings.diskSize for these resources.

jasonvigil commented 3 months ago

WIP: the disk size field isn't updating

Edit: fixed

google-oss-prow[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yuwenma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/master/OWNERS)~~ [yuwenma] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment