search

GoogleCloudPlatform / k8s-config-connector

GCP Config Connector, a Kubernetes add-on for managing GCP resources
https://cloud.google.com/config-connector/docs/overview
Apache License 2.0
861 stars 202 forks source link

proto-to-mapper: log missing objects at V(2) #2078

Closed justinsb closed 1 week ago

justinsb commented 2 weeks ago

These are not unexpected now we're processing (almost) all GCP APIs; we don't expect go types for the whole API (yet).

Logging hides any important messages and also slows down the process.

yuwenma commented 1 week ago

/lgtm /approve

google-oss-prow[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yuwenma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/master/OWNERS)~~ [yuwenma] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment