search

GoogleCloudPlatform / k8s-config-connector

GCP Config Connector, a Kubernetes add-on for managing GCP resources
https://cloud.google.com/config-connector/docs/overview
Apache License 2.0
861 stars 201 forks source link

Golden output for immutable fields of gkehubfeaturemembership #2119

Open ziyue-101 opened 1 week ago

ziyue-101 commented 1 week ago

Change description

For the gkehub resource, all immutable fields are references, Currently, If we change the references field, the status says the dependent object can't be found.

If we switch to test with the new controller, the error message will be changed as sth like "immutable fields update failed"

Tests you have done

ziyue-101 commented 1 week ago

/assign @justinsb /assign @yuwenma

google-oss-prow[bot] commented 6 days ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from justinsb. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment