search

GoogleCloudPlatform / k8s-config-connector

GCP Config Connector, a Kubernetes add-on for managing GCP resources
https://cloud.google.com/config-connector/docs/overview
Apache License 2.0
861 stars 201 forks source link

chore: install protoc in proto-to-mapper #2121

Closed yuwenma closed 1 week ago

yuwenma commented 1 week ago

Install protoc cmd as prerequisite to run make generate-pb

justinsb commented 1 week ago

Good idea. We could also use the approach in mockgcp/Makefile, but that is currently architecture & OS dependent, so ...

/approve /lgtm

google-oss-prow[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/master/OWNERS)~~ [justinsb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment