search

GoogleCloudPlatform / k8s-config-connector

GCP Config Connector, a Kubernetes add-on for managing GCP resources
https://cloud.google.com/config-connector/docs/overview
Apache License 2.0
861 stars 201 forks source link

Support observed state validation via GitHub action #2128

Open maqiuyujoyce opened 1 week ago

maqiuyujoyce commented 1 week ago

Change description

Leveraged the VCR testing and the golden object comparison to verify that observed state fields are populated properly after a successful reconciliation.

Added the observed state test into the presubmit test.

Added instructions about how to generate observed state test data.

Tests you have done

google-oss-prow[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from maqiuyujoyce. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment