search

GoogleCloudPlatform / k8s-config-connector

GCP Config Connector, a Kubernetes add-on for managing GCP resources
https://cloud.google.com/config-connector/docs/overview
Apache License 2.0
861 stars 201 forks source link

refactor: Refactor lifecyclehandler test to avoid circular dependency #2133

Closed justinsb closed 6 days ago

justinsb commented 1 week ago

This test was using the full controller test machinery, which caused circular dependencies when we used the lifecycle handler in controllers.

justinsb commented 1 week ago

/assign @yuwenma

yuwenma commented 1 week ago

/lgtm /approve

I like the direction of this PR.

google-oss-prow[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yuwenma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/master/OWNERS)~~ [yuwenma] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
yuwenma commented 1 week ago

/hold one question to confirm the env var. Feel free to unhold

yuwenma commented 6 days ago

/hold cancel