fix: change CBWP CRD field to camel case

GoogleCloudPlatform / k8s-config-connector

GCP Config Connector, a Kubernetes add-on for managing GCP resources

https://cloud.google.com/config-connector/docs/overview

Apache License 2.0

861 stars 201 forks source link

fix: change CBWP CRD field to camel case #2137

Closed yuwenma closed 1 week ago

yuwenma commented 1 week ago

The CBWP v1alpha1 is released in 1.119.0. We can pick up this fix in 1.120.0

Test

Added a apichecks test to guarantee all CRDs field use camel case rather than pascal case.

Before fix, the test output is

[refs] crd=cloudbuildworkerpools.cloudbuild.cnrm.cloud.google.com version=v1alpha1: field ".spec.privatePoolV1Config.networkConfig.PeeredNetworkIPRange" should use camel case

justinsb commented 1 week ago

I have some suggestions on the linter rule, but nothing that blocks the field rename so 👍

google-oss-prow[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/master/OWNERS)~~ [justinsb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment