search

GoogleCloudPlatform / k8s-config-connector

GCP Config Connector, a Kubernetes add-on for managing GCP resources
https://cloud.google.com/config-connector/docs/overview
Apache License 2.0
861 stars 201 forks source link

Deduplicate string replacement for startTime #2139

Closed ziyue-101 closed 1 week ago

ziyue-101 commented 1 week ago

Change description

Normalize startTime in the NormalizeHTTPLog, which is used in both script test and fixture test so we have more normalization than before

Tests you have done

ziyue-101 commented 1 week ago

/assign @yuwenma

google-oss-prow[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yuwenma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/master/OWNERS)~~ [yuwenma] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment