search

GoogleCloudPlatform / k8s-config-connector

GCP Config Connector, a Kubernetes add-on for managing GCP resources
https://cloud.google.com/config-connector/docs/overview
Apache License 2.0
860 stars 199 forks source link

monitoringdashboard: Add alertChart #2155

Closed justinsb closed 3 days ago

justinsb commented 5 days ago
google-oss-prow[bot] commented 4 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yuwenma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/master/OWNERS)~~ [yuwenma] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
justinsb commented 4 days ago

Implemented the suggested nil-pointer check changes

yuwenma commented 3 days ago

/lgtm

Thanks! One more comment (no blocker) about if we want to add spec.projectRef

yuwenma commented 3 days ago

/hold cancel