chore: cbwp change status networkRef to external

GoogleCloudPlatform / k8s-config-connector

GCP Config Connector, a Kubernetes add-on for managing GCP resources

https://cloud.google.com/config-connector/docs/overview

Apache License 2.0

860 stars 199 forks source link

chore: cbwp change status networkRef to external #2164

Closed yuwenma closed 4 days ago

yuwenma commented 4 days ago

Follow up to the offline discussion on https://github.com/GoogleCloudPlatform/k8s-config-connector/pull/2145#discussion_r1654354648

Summary:

spec should use Ref
status.observedState should use plain external link.
Both structs can use kcc:proto go tag, but need to be separate to split the spec and status CRD fields.

justinsb commented 4 days ago

/approve /lgtm

google-oss-prow[bot] commented 4 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/master/OWNERS)~~ [justinsb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment