GoogleCloudPlatform / k8s-config-connector

GCP Config Connector, a Kubernetes add-on for managing GCP resources
https://cloud.google.com/config-connector/docs/overview
Apache License 2.0
888 stars 219 forks source link

monitoringdashboard: add support for xyChart dataSets.targetAxis and y2Axis #2167

Closed justinsb closed 3 months ago

google-oss-prow[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yuwenma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/master/OWNERS)~~ [yuwenma] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
yuwenma commented 3 months ago

/lgtm

justinsb commented 3 months ago

I'm a little worried that this one is failing because of server-side defaulting causing a diff (on the y1Axis, I think), hence #2169

justinsb commented 3 months ago

/hold

The http log is suspicious here...

justinsb commented 3 months ago

/hold cancel

I reviewed the full http.log; it looks right. The diff is confusing though!

yuwenma commented 3 months ago

/hold cancel

I reviewed the full http.log; it looks right. The diff is confusing though!

Do you mean the timeSeriesTable? Agree it's confusing. I think that code is actually merged https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/b5a5611408a8949faae46c2a9744dad4814125b8/pkg/test/resourcefixture/testdata/basic/monitoring/v1beta1/monitoringdashboard/monitoringdashboardfull/_http.log#L784-L809

yuwenma commented 3 months ago

/lgtm