search

GoogleCloudPlatform / k8s-config-connector

GCP Config Connector, a Kubernetes add-on for managing GCP resources
https://cloud.google.com/config-connector/docs/overview
Apache License 2.0
888 stars 219 forks source link

Add observed state test for ContainerNodePool #2168

Closed maqiuyujoyce closed 3 days ago

maqiuyujoyce commented 3 months ago

Change description

Diffbase #2128

Changes is in commit 5dcfec07d36a8674a55000be3c06a3de82908765.

Tests you have done

google-oss-prow[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from maqiuyujoyce. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
maqiuyujoyce commented 3 months ago

tests-e2e-fixtures failed because obviously the golden object generated by mock and the golden object generated by vcr are different. We probably need to have two versions of golden object.

maqiuyujoyce commented 3 days ago

Will get to it after the ContainerNodePool is migrated to use the direct controller.