search

GoogleCloudPlatform / k8s-config-connector

GCP Config Connector, a Kubernetes add-on for managing GCP resources
https://cloud.google.com/config-connector/docs/overview
Apache License 2.0
860 stars 199 forks source link

move refs for monitoringdashboard #2176

Closed justinsb closed 3 days ago

justinsb commented 4 days ago
justinsb commented 4 days ago

This is moving the MonitoringAlertPolicyRef to refs/v1beta1, with the other refs.

TBH I'm not sure whether we should centralize them, or whether there is going to be enough per-service logic that we want to distribute them. We might want to wait-and-see, but moving them is pretty easy anyway.

/assign @yuwenma

yuwenma commented 3 days ago

/lgtm /approve

google-oss-prow[bot] commented 3 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yuwenma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/master/OWNERS)~~ [yuwenma] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
yuwenma commented 3 days ago

/hold Need another look. This PR seems to contain unrelated changes.