search

GoogleCloudPlatform / k8s-config-connector

GCP Config Connector, a Kubernetes add-on for managing GCP resources
https://cloud.google.com/config-connector/docs/overview
Apache License 2.0
861 stars 202 forks source link

mockgcp: support enum-encoding=int alt specifier #2203

Closed justinsb closed 4 days ago

justinsb commented 4 days ago

Clients can specify a query parameter of $alt=json;enum-encoding=int (with some escaping) to get integer encoded values from protos.

We support this for more fidelity with mockgcp (though it does make things a bit harder to read - ideally the clients would not do this, but if we use the default clients we don't have full control here)

google-oss-prow[bot] commented 4 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yuwenma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/master/OWNERS)~~ [yuwenma] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment