GoogleCloudPlatform / k8s-config-connector

GCP Config Connector, a Kubernetes add-on for managing GCP resources
https://cloud.google.com/config-connector/docs/overview
Apache License 2.0
861 stars 202 forks source link

tests: err out if skeleton non null #2208

Open acpana opened 4 days ago

acpana commented 4 days ago

Related to #2135

google-oss-prow[bot] commented 4 days ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from acpana. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
acpana commented 4 days ago

Current offenders:

    resourceskeleton_test.go:76: error skeleton is not null but resource doesn't support NewFromUri 'CertificateManagerCertificate': https://certificatemanager.googleapis.com/v1/projects/kcc-test/locations/europe-west1/certificates/certificate-test?alt=json
    resourceskeleton_test.go:76: error skeleton is not null but resource doesn't support NewFromUri 'CertificateManagerCertificateMap': https://certificatemanager.googleapis.com/v1/projects/kcc-test/locations/global/certificateMaps/certificatemap-test?alt=json
    resourceskeleton_test.go:76: error skeleton is not null but resource doesn't support NewFromUri 'CertificateManagerCertificateMapEntry': https://certificatemanager.googleapis.com/v1/projects/kcc-test/locations/global/certificateMaps/certificatemap-test/certificateMapEntries/certificatemapentry-test?alt=json
    resourceskeleton_test.go:76: error skeleton is not null but resource doesn't support NewFromUri 'CertificateManagerDNSAuthorization': https://certificatemanager.googleapis.com/v1/projects/kcc-test/locations/global/dnsAuthorizations/dnsauthorization-test?alt=json
    resourceskeleton_test.go:76: error skeleton is not null but resource doesn't support NewFromUri 'EdgeContainerCluster': https://edgecontainer.googleapis.com/v1/projects/kcc-test/locations/us-central1/clusters/edgecontainercluster-test
    resourceskeleton_test.go:76: error skeleton is not null but resource doesn't support NewFromUri 'EdgeContainerNodePool': https://edgecontainer.googleapis.com/v1/projects/kcc-test/locations/us-central1/clusters/edgecontainercluster-test/nodePools/edgecontainernodepool-test
    resourceskeleton_test.go:76: error skeleton is not null but resource doesn't support NewFromUri 'EdgeContainerVpnConnection': https://edgecontainer.googleapis.com/v1/projects/kcc-test/locations/us-central1/vpnConnections/edgecontainervpnconnection-test
    resourceskeleton_test.go:76: error skeleton is not null but resource doesn't support NewFromUri 'VertexAIDataset': https://us-central1-aiplatform.googleapis.com/v1beta1/projects/kcc-test/locations/us-central1/datasets/1234567890?alt=json
    resourceskeleton_test.go:76: error skeleton is not null but resource doesn't support NewFromUri 'VertexAIEndpoint': https://us-central1-aiplatform.googleapis.com/v1beta1/projects/kcc-test/locations/us-central1/endpoints/vertexaiendpoint-test
    resourceskeleton_test.go:76: error skeleton is not null but resource doesn't support NewFromUri 'VertexAIIndex': https://us-central1-aiplatform.googleapis.com/v1beta1/projects/kcc-test/locations/us-central1/indexes/vertexaiindex-test
    resourceskeleton_test.go:76: error skeleton is not null but resource doesn't support NewFromUri 'CloudIDSEndpoint': https://ids.googleapis.com/projects/kcc-test/locations/us-west2-a/endpoints/cloudidsendpoint-ppdtifqxy4vqi4ezx7la
    resourceskeleton_test.go:76: error skeleton is not null but resource doesn't support NewFromUri 'ComputeManagedSSLCertificate': https://www.googleapis.com/compute/v1/projects/kcc-test/global/sslCertificates/computemanagedsslcertificate-wj6kvvmztb67xscbzd5a
jingyih commented 3 days ago

/cc

jingyih commented 2 hours ago

Attempting to fix Vertex AI resources in #2244.