ConfigConnectorContext should be fetched when 'spec.mode' in ConfigConnector is not set

GoogleCloudPlatform / k8s-config-connector

GCP Config Connector, a Kubernetes add-on for managing GCP resources

https://cloud.google.com/config-connector/docs/overview

Apache License 2.0

881 stars 215 forks source link

ConfigConnectorContext should be fetched when 'spec.mode' in ConfigConnector is not set #2300

Closed maqiuyujoyce closed 2 months ago

maqiuyujoyce commented 2 months ago

Change description

Fetch the ConfigConnectorContext object when the ConfigConnector object exists but spec.mode is unset.

Mode in ConfigConnector is defaulted to namespaced (code logic here) so it's valid to have spec.mode unset in it.

Tests you have done

[N/A] Run make ready-pr to ensure this PR is ready for review.
[N/A] Perform necessary E2E testing for changed resources.

google-oss-prow[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/master/OWNERS)~~ [justinsb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment