GoogleCloudPlatform / k8s-config-connector

GCP Config Connector, a Kubernetes add-on for managing GCP resources
https://cloud.google.com/config-connector/docs/overview
Apache License 2.0
894 stars 226 forks source link

build: make commit hash for googlapis configurable #2314

Closed jingyih closed 3 months ago

jingyih commented 3 months ago

Optionally allow developers to specify a commit hash to pull from googleapis.

The default behavior is still the same - pull from HEAD.

Specifying a commit hash could be useful when

google-oss-prow[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/master/OWNERS)~~ [justinsb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
justinsb commented 3 months ago

I love it!

jingyih commented 3 months ago

/retest