Fixes for the first composition sample

barney-s commented 3 months ago

Use generated CRD instead of Facade
change the CRD group to make it generic
change the facade to get the list of team members instead of apps
Update the landing page configmap to use the list of team members instead of apps

justinsb commented 3 months ago

Would be really nice to have a unit test and check in the output of running a composition (a golden test). But not a blocker!

/approve /lgtm

google-oss-prow[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/master/OWNERS)~~ [justinsb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

GoogleCloudPlatform / k8s-config-connector

Fixes for the first composition sample #2318