search

GoogleCloudPlatform / k8s-config-connector

GCP Config Connector, a Kubernetes add-on for managing GCP resources
https://cloud.google.com/config-connector/docs/overview
Apache License 2.0
894 stars 226 forks source link

mockgcp: more fidelity for secretmanager #2320

Closed justinsb closed 3 months ago

justinsb commented 3 months ago
justinsb commented 3 months ago

This is because the automatic update PR #2311 was failing because we were (incorrectly) responding with all fields for secret manager from mockgcp.

cheftako commented 3 months ago

Looks good. Would like answers for Policy.Version and projectId before making it official.

cheftako commented 3 months ago

/lgtm /approve

google-oss-prow[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/master/OWNERS)~~ [cheftako] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment