Remove 'state-into-spec' annotation from reference docs

GoogleCloudPlatform / k8s-config-connector

GCP Config Connector, a Kubernetes add-on for managing GCP resources

https://cloud.google.com/config-connector/docs/overview

Apache License 2.0

881 stars 215 forks source link

Remove 'state-into-spec' annotation from reference docs #2322

Closed maqiuyujoyce closed 1 month ago

maqiuyujoyce commented 1 month ago

Change description

We should avoid mentioning the state-into-spec annotation so removing it from reference docs.

Tests you have done

[N/A] Run make ready-pr to ensure this PR is ready for review.
[N/A] Perform necessary E2E testing for changed resources.

gemmahou commented 1 month ago

/lgtm /approve /hold

I remember we have the state-into-spec annotation in some golden logs(code). Do we want to update them to avoid diffs in golden tests?

google-oss-prow[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gemmahou

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/master/OWNERS)~~ [gemmahou] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

maqiuyujoyce commented 1 month ago

state-into-spec annotation is still functioning as before, so the golden logs should have this annotation. This PR is to remove it from the docs and stop advertising this feature.

yuwenma commented 1 month ago

/hold cancel

Lovely! Thank you.