GoogleCloudPlatform / k8s-config-connector

GCP Config Connector, a Kubernetes add-on for managing GCP resources
https://cloud.google.com/config-connector/docs/overview
Apache License 2.0
881 stars 215 forks source link

Add basic mockgcp test cases for CloudSQL #2324

Closed jasonvigil closed 1 month ago

jasonvigil commented 1 month ago

These test cases specify the "required" fields for postgres, mysql, and sqlserver and include updates for the non-immutable fields.

yuwenma commented 1 month ago

Looks good! Have some minor comments.

google-oss-prow[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yuwenma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/master/OWNERS)~~ [yuwenma] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
yuwenma commented 1 month ago

/lgtm

yuwenma commented 1 month ago

/hold cancel