Closed jasonvigil closed 1 month ago
Looks good! Have some minor comments.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: yuwenma
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/lgtm
/hold cancel
These test cases specify the "required" fields for postgres, mysql, and sqlserver and include updates for the non-immutable fields.
make ready-pr
to ensure this PR is ready for review.