search

GoogleCloudPlatform / k8s-config-connector

GCP Config Connector, a Kubernetes add-on for managing GCP resources
https://cloud.google.com/config-connector/docs/overview
Apache License 2.0
881 stars 215 forks source link

differentiate aks/eks oidc issuer name in composition samples #2333

Closed jiefenghe closed 1 month ago

jiefenghe commented 1 month ago

use different suffix for aks/eks oidc issuer configmap to avoid conflict if customer is using the same name for different type of clusters

Change description

use different suffix for aks/eks oidc issuer configmap to avoid conflict if customer is using the same name for different type of clusters

Tests you have done

barney-s commented 1 month ago

/lgtm /approve

google-oss-prow[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: barney-s

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/master/OWNERS)~~ [barney-s] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment