search

GoogleCloudPlatform / k8s-config-connector

GCP Config Connector, a Kubernetes add-on for managing GCP resources
https://cloud.google.com/config-connector/docs/overview
Apache License 2.0
902 stars 234 forks source link

chore: skip update client in ready-pr #3210

Closed yuwenma closed 3 days ago

yuwenma commented 6 days ago

related to #3037

maqiuyujoyce commented 5 days ago

/lgtm /approve

Do we plan to remove the go client generated by make generate-go-client soon?

yuwenma commented 5 days ago

/lgtm /approve

Do we plan to remove the go client generated by make generate-go-client soon?

We don't. Here's more details about the plan. I will announce it in 1.126 release.

maqiuyujoyce commented 5 days ago

Sounds good.

maqiuyujoyce commented 3 days ago

/lgtm /approve

google-oss-prow[bot] commented 3 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maqiuyujoyce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/master/OWNERS)~~ [maqiuyujoyce] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment