chore: improvements around Direct identity and external

GoogleCloudPlatform / k8s-config-connector

GCP Config Connector, a Kubernetes add-on for managing GCP resources

https://cloud.google.com/config-connector/docs/overview

Apache License 2.0

902 stars 234 forks source link

chore: improvements around Direct identity and external #3212

Closed yuwenma closed 5 days ago

yuwenma commented 5 days ago

Improvements:

Separate resource Identity and external Ref
Added in-line comments to guide the contributors on the functionality and expected behaviors.
Make the variable names shorter. e.g. SecretManagerSecretVersion --> SecretVersion
Applied some best practice like introducing the CompareProtoMessage

Fixes:

Remove parent from the reference API to avoid the json tag hack, and potential client-go unstructured parsing issues.
Parent and Identity should be read-only for adapter.

justinsb commented 5 days ago

A few thoughts but nothing blocking.

/approve /lgtm

justinsb commented 5 days ago

BTW I tried using your suggested approach for the ID in https://github.com/GoogleCloudPlatform/k8s-config-connector/pull/2953 and I like it.

I personally find it easier to write the code first, and then update the template, but not a problem!

google-oss-prow[bot] commented 5 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/master/OWNERS)~~ [justinsb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment