search

GoogleCloudPlatform / k8s-config-connector

GCP Config Connector, a Kubernetes add-on for managing GCP resources
https://cloud.google.com/config-connector/docs/overview
Apache License 2.0
902 stars 234 forks source link

feat: A new parent interface #3234

Open yuwenma opened 5 days ago

yuwenma commented 5 days ago

Change description

Fixes #

Tests you have done

justinsb commented 3 days ago

So I think two blockers, and everything else we can tackle in follow-up PRs:

google-oss-prow[bot] commented 13 hours ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from justinsb. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
yuwenma commented 13 hours ago

So I think two blockers, and everything else we can tackle in follow-up PRs:

  • I think we need a fallback to name?
  • I don't think you can remove the kind field

I reverted the changes to BQCC. So this PR only contains the interface and the implemented ProjectParent and ProjectAndLocationParent