search

GoogleCloudPlatform / k8s-config-connector

GCP Config Connector, a Kubernetes add-on for managing GCP resources
https://cloud.google.com/config-connector/docs/overview
Apache License 2.0
902 stars 234 forks source link

Adding MemorystoreInstance v1alpha1 API #3239

Open himanikh opened 4 days ago

himanikh commented 4 days ago

Change description

Adding MemorystoreInstance v1alpha1 API

google-oss-prow[bot] commented 4 days ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign justinsb for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
anhdle-sso commented 5 hours ago

/lgtm

We just need to remove the todo. Also, Can you change the PR description to Adding MemorystoreInstance v1alpha1 API to be more specific?

anhdle-sso commented 4 hours ago

/lgtm