search

GoogleCloudPlatform / k8s-config-connector

GCP Config Connector, a Kubernetes add-on for managing GCP resources
https://cloud.google.com/config-connector/docs/overview
Apache License 2.0
902 stars 234 forks source link

mockgcp: use correct version in selfLink #3248

Closed justinsb closed 13 hours ago

justinsb commented 2 days ago

Rather than hard-code the version, we add the request path into the context. Then we can extract the version and use that version.

Also add some normalization that was missed so that we are compatible with real GCP.

yuwenma commented 13 hours ago

/lgtm /approve

Thank you!

cc @gemmahou

google-oss-prow[bot] commented 13 hours ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yuwenma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/master/OWNERS)~~ [yuwenma] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment