Adding an e2e test to verify an HTTPS ingress

GoogleCloudPlatform / k8s-multicluster-ingress

kubemci: Command line tool to configure L7 load balancers using multiple kubernetes clusters

Apache License 2.0

377 stars 68 forks source link

Adding an e2e test to verify an HTTPS ingress #100

Closed nikhiljindal closed 6 years ago

nikhiljindal commented 6 years ago

Ref https://github.com/GoogleCloudPlatform/k8s-multicluster-ingress/issues/46

Updating the e2e test script to verify an HTTPS ingress. ~~Also fixing a bug in deleting SSL cert in the process. SSL cert can not be deleted before the target proxy using it is deleted.~~

cc @G-Harmon @csbell

nikhiljindal commented 6 years ago

Updated to remove the SSL cert deletion bug fix and moved it to https://github.com/GoogleCloudPlatform/k8s-multicluster-ingress/pull/102

coveralls commented 6 years ago

Changes Unknown when pulling eed3e582d0c92d58859c1d0819bae7b12fec1493 on nikhiljindal:listHttps into on GoogleCloudPlatform:master.

coveralls commented 6 years ago

Changes Unknown when pulling eed3e582d0c92d58859c1d0819bae7b12fec1493 on nikhiljindal:listHttps into on GoogleCloudPlatform:master.

G-Harmon commented 6 years ago

nice.

Reviewed 3 of 3 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

coveralls commented 6 years ago

Changes Unknown when pulling f6e53ccc6ad5bd8ddb8d204a4fe5f41ac7092759 on nikhiljindal:listHttps into on GoogleCloudPlatform:master.

coveralls commented 6 years ago

Changes Unknown when pulling f6e53ccc6ad5bd8ddb8d204a4fe5f41ac7092759 on nikhiljindal:listHttps into on GoogleCloudPlatform:master.

nikhiljindal commented 6 years ago

Rebased to include #103 and verified that the test e2e test still passes.