search

GoogleCloudPlatform / k8s-multicluster-ingress

kubemci: Command line tool to configure L7 load balancers using multiple kubernetes clusters
Apache License 2.0
377 stars 68 forks source link

e2e test improvements: run "kubemci list" and more error checking #103

Closed G-Harmon closed 6 years ago

G-Harmon commented 6 years ago

reviewers: @nikhiljindal cc: @csbell @madhusudancs

Nikhil, I know you have a PR out for the e2e test now as well. It might be easier if this one goes in first? They both touch a lot of this file.

This change is Reviewable

k8s-ci-robot commented 6 years ago

Hi @G-Harmon. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
nikhiljindal commented 6 years ago

/ok-to-test

nikhiljindal commented 6 years ago

ok I will wait to review this one before merging the other one

coveralls commented 6 years ago

Coverage Status

Changes Unknown when pulling afd413db310623d7c5b622503fe5d46baf2f59d3 on G-Harmon:mciList into on GoogleCloudPlatform:master.

nikhiljindal commented 6 years ago

Looks great with minor nits. Will merge this and then rebase and fix nits in https://github.com/GoogleCloudPlatform/k8s-multicluster-ingress/pull/100

G-Harmon commented 6 years ago

okay, thanks for fixing up my PR and merging it :)