search

GoogleCloudPlatform / k8s-multicluster-ingress

kubemci: Command line tool to configure L7 load balancers using multiple kubernetes clusters
Apache License 2.0
377 stars 68 forks source link

If kubemci changes a service, ingress-gce won't notice that #104

Closed G-Harmon closed 6 years ago

G-Harmon commented 6 years ago

@nicksardo reported a potential bug in the interaction between kubemci and ingress-gce: "When a service change is observed, it normally scans through all ingresses to determine whether it should enqueue the ingress for sync. It only checks GCEIngress, not GCEMultiClusterIngress" In this code: https://github.com/kubernetes/ingress-gce/blob/master/pkg/controller/controller.go#L192-L205

I don't think we change the service, but I wanted @nikhiljindal or @csbell to verify this.

nikhiljindal commented 6 years ago

  1. kubemci never changes any service. User can update the service.

  2. When user updates the service, yes we do not enque multucluster ingress again. Even if we did enque multi cluster ingresses, ingress-gce wont do anything. It manages instance groups only. Users will need to run kubemci create again to update healthcheck, urlmap or other resources.

So while there is no harm in enqueuing multicluster ingresses, we wont gain anything either.

nikhiljindal commented 6 years ago

Closing as I dont think we need to do anything here. Feel free to reopen if required.