search

GoogleCloudPlatform / k8s-multicluster-ingress

kubemci: Command line tool to configure L7 load balancers using multiple kubernetes clusters
Apache License 2.0
377 stars 68 forks source link

Use correct kubeconfig when creating secret in e2e #112

Closed glindstedt closed 6 years ago

glindstedt commented 6 years ago

Currently the secret will be created in whatever clusters/namespaces you've configured in your normal kubeconfig.

k8s-ci-robot commented 6 years ago

Hi @glindste. Thanks for your PR.

I'm waiting for a kubernetes or GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
nikhiljindal commented 6 years ago

/ok-to-test

nikhiljindal commented 6 years ago

/lgtm, thx!

We should create a var kubectlArgs := []string{"kubectl", fmt.Sprintf("--kubeconfig=%s", kubeConfigPath)} at the top and use that everywhere to prevent this from happening again. We never want to use kubectl without --kubeconfig.

coveralls commented 6 years ago

Coverage Status

Changes Unknown when pulling 9692f7fe26e9ebf646f721c69736274db1364487 on glindste:fix-e2e-bug into on GoogleCloudPlatform:master.