GoogleCloudPlatform / k8s-multicluster-ingress

kubemci: Command line tool to configure L7 load balancers using multiple kubernetes clusters
Apache License 2.0
377 stars 68 forks source link

Health check from probe e2e test #113

Closed glindstedt closed 6 years ago

glindstedt commented 6 years ago

Fixes #108. I refactored the basic case slightly so we could reuse part of the setup for other tests.

TODO:

k8s-ci-robot commented 6 years ago

Hi @glindste. Thanks for your PR.

I'm waiting for a kubernetes or GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
nikhiljindal commented 6 years ago

/ok-to-test

coveralls commented 6 years ago

Coverage Status

Changes Unknown when pulling 4155ae6f4e71f3081252460b55e7e3eb68eb83bb on glindste:hc-e2e into on GoogleCloudPlatform:master.

nikhiljindal commented 6 years ago

Thanks @glindste This looks great! Added a few comments.

coveralls commented 6 years ago

Coverage Status

Changes Unknown when pulling d8dba868f81c9b0730b83c9c1134cfcf0f3e600c on glindste:hc-e2e into on GoogleCloudPlatform:master.

nikhiljindal commented 6 years ago

Thx for the fixes @glindste Looks great modulo the remaining TODO for refactoring test methods.

glindstedt commented 6 years ago

I broke out some of the common operations into functions. Let me know if you have any comments, otherwise I'm finished and can squash the commits.

nikhiljindal commented 6 years ago

Thanks @glindste This looks great!

Please squash commits and I will merge.

glindstedt commented 6 years ago

Squashed, feel free to merge!

nikhiljindal commented 6 years ago

Thanks @glindste !!