Closed glindstedt closed 6 years ago
Hi @glindste. Thanks for your PR.
I'm waiting for a kubernetes or GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
I understand the commands that are listed here.
/ok-to-test
Thanks @glindste This looks great! Added a few comments.
Thx for the fixes @glindste Looks great modulo the remaining TODO for refactoring test methods.
I broke out some of the common operations into functions. Let me know if you have any comments, otherwise I'm finished and can squash the commits.
Thanks @glindste This looks great!
Please squash commits and I will merge.
Squashed, feel free to merge!
Thanks @glindste !!
Fixes #108. I refactored the basic case slightly so we could reuse part of the setup for other tests.
TODO: