search

GoogleCloudPlatform / k8s-multicluster-ingress

kubemci: Command line tool to configure L7 load balancers using multiple kubernetes clusters
Apache License 2.0
377 stars 68 forks source link

Adding support for frontend HTTPS with pre shared certs #116

Closed nikhiljindal closed 6 years ago

nikhiljindal commented 6 years ago

Ref https://github.com/GoogleCloudPlatform/k8s-multicluster-ingress/issues/46

Adding support for frontend HTTPS with pre shared certs

cc @G-Harmon @csbell @madhusudancs

coveralls commented 6 years ago

Coverage Status

Changes Unknown when pulling a3d3268a020eea0e69feee5bdf64c5c390a90393 on nikhiljindal:https2 into on GoogleCloudPlatform:master.

coveralls commented 6 years ago

Coverage Status

Changes Unknown when pulling a3d3268a020eea0e69feee5bdf64c5c390a90393 on nikhiljindal:https2 into on GoogleCloudPlatform:master.

nikhiljindal commented 6 years ago

friendly ping

nikhiljindal commented 6 years ago

Thanks for the review @G-Harmon

Regarding coverage: its 50% because ive tested 9 lines out of 18. Out of those 9 lines, 7 are comments and 2 are package includes :)

TIL deleting comments can increase code coverage :)

G-Harmon commented 6 years ago

LGTM.

TIL deleting comments can increase code coverage :)

heh, that's not a very smart coverage tool, then! But don't you test EnsureSSLCert? Seems like that should give you a higher coverage result?

nikhiljindal commented 6 years ago

But don't you test EnsureSSLCert? Seems like that should give you a higher coverage result?

That 50% is only for the lines that I am adding in this PR. I am testing 9 of the 18 lines that am adding in this PR.